feat: convert datetime values to RFC 3339 in WebDAV search literals#358
Merged
Conversation
Signed-off-by: bigcat88 <bigcat88@icloud.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 95.13% 95.14%
=======================================
Files 45 45
Lines 5325 5333 +8
=======================================
+ Hits 5066 5074 +8
Misses 259 259
🚀 New features to boost your workflow:
|
Signed-off-by: bigcat88 <bigcat88@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #347 .
This PR fixes incorrect handling of
datetimeanddateobjects in WebDAVfind()queries. Previously, passing adatetimeresulted in an invalid string format like2025-03-10 12:34:56.123456, causing Nextcloud to misinterpret the value in<d:literal>.Changes made:
_dav_literal()helper to format datetime values as RFC 3339 strings (2025-03-10T12:34:56Z)build_search_req()to use this helper when generating<d:literal>valuesThis ensures proper comparison logic for operators like
"gt"and"lt"when filtering bylast_modifiedor other time-based properties.Fixes issues where files were incorrectly included or excluded due to string-based comparison.